Merged
Conversation
jwtty
force-pushed
the
stagerun-e2e
branch
3 times, most recently
from
7c8c67d to
900db57
Compare
| // +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string | ||
| // +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="Resource-Snapshot",type=string | ||
| // +kubebuilder:printcolumn:JSONPath=`.status.policySnapshotIndexUsed`,name="Policy-Snapshot",type=string | ||
| // +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="Resource-Snapshot-Index",type=string |
Contributor
There was a problem hiding this comment.
I am not 100% sure the new name is better
Contributor
Author
There was a problem hiding this comment.
With the fix to use index, instead of name, it only shows a number: e.g. "0", "1". I feel it's better to indicate it's an index.
Comment on lines
+203
to
+204
| // Mark the delete stage as started in case it's not. | ||
| markStageUpdatingStarted(updateRun.Status.DeletionStageStatus, updateRun.Generation) |
Contributor
There was a problem hiding this comment.
is this idempotent? will it change the LTT or something else?
Contributor
Author
There was a problem hiding this comment.
yes, it's idempotent. What's LTT? The startTime is only set when it's nil. The condition does not change.
ryanzhang-oss
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add e2e tests for staged update run feature.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer